Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved report pagination fix #2258

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Saved report pagination fix #2258

merged 1 commit into from
Oct 2, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Sep 28, 2017

This PR aligns the styling of the "saved reports" pagination bar with the standard ui-components based pagination bar. It also removes extraneous borders from all the pagination bars.

https://bugzilla.redhat.com/show_bug.cgi?id=1489136

Old
screen shot 2017-09-28 at 3 32 26 pm

New
screen shot 2017-09-28 at 3 31 07 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label, bug, formatting/styling, fine/no

@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2017

@epwinchell Cannot apply the following label because they are not recognized:

@epwinchell
Copy link
Contributor Author

@miq-bot assign @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/e14f9cb62296a02ba6f15def439833ebd759416e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Oct 2, 2017
@mzazrivec mzazrivec added this to the Sprint 70 Ending Oct 2, 2017 milestone Oct 2, 2017
@mzazrivec mzazrivec merged commit 88a979d into ManageIQ:master Oct 2, 2017
@epwinchell epwinchell deleted the saved_report_paging_fix branch October 2, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants