Adding miq_date parameter when setting hourly and daily vars #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Middleware timeline uses miq_date to send the chosen date to the UI backend, thus was being ignored. Changing update_from_params to read miq_date if received, but giving priority to miq_date_1.
|
@miq-bot add_label bug, middleware, timelines |
|
Checked commit israel-hdez@993d9c5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@karelhala @mtho11 please review |
|
@abonas screenshot added |
|
@mtho11 @martinpovolny ping!? |
|
@israel-hdez looks good and pretty much straight forward. @martinpovolny what do you think, is it justifiable for us to use different param since |
mtho11
approved these changes
Oct 3, 2017
karelhala
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware timeline uses
miq_dateto send the chosen date to the UI backend, thus was being ignored.Changing update_from_params to read miq_date if received, but giving priority to miq_date_1.
This PR is part of a collection of PRs solving ManageIQ/manageiq#15756.