Cloud networks are being listed not only in the CloudNetworkController. #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit martinpovolny@e38cbd8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Ah, I see what you mean - it worked for subnets, but not for networks; I've verified that this fix allows it to work for both. Thanks! |
|
@tzumainn I'm merging this fix, but can you take action to have someone add a test to catch this? Thx, Dan |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this trying to reproduce:
https://bugzilla.redhat.com/show_bug.cgi?id=1494340
https://bugzilla.redhat.com/show_bug.cgi?id=1494341
The BZs' description do not match exactly what I saw and there's no log attached in the BZs, but doing the steps I hit into this one.
W/o this fix I cannot get to the place to reproduce the bug and with this fix I can, but cannot reproduce the bug.
@lpichler : please, review
@tzumainn : please, take a look at the BZ and let me know if this fixes the problem for you.
This seems to be a regression but also it seems there's no test coverage around this functionality.