Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed code to render custom buttons toolbar on provider dashboard view #2212

Conversation

h-kataria
Copy link
Contributor

Fixed code to render custom buttons toolbar when switching Textual summary to Dashboard view for a selected Provider

https://bugzilla.redhat.com/show_bug.cgi?id=1492361

@dclarizio please review.
@lgalis please review/test

before:
before

after:
after

Fixed code to render custom buttons toolbar when switching Textual summary to Dashboard view for a selected Provider

https://bugzilla.redhat.com/show_bug.cgi?id=1492361
@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2017

Checked commit h-kataria@9048817 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio self-assigned this Sep 21, 2017
@lgalis
Copy link
Contributor

lgalis commented Sep 21, 2017

@dclarizio , @h-kataria - looks good - tested the changes in the UI

@mzazrivec mzazrivec self-assigned this Sep 22, 2017
@mzazrivec mzazrivec added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 22, 2017
@mzazrivec mzazrivec merged commit 3d763ac into ManageIQ:master Sep 22, 2017
@h-kataria h-kataria deleted the show_custom_buttons_on_provider_dashboard_screen branch October 3, 2017 18:37
simaishi pushed a commit that referenced this pull request Nov 13, 2017
…er_dashboard_screen

Fixed code to render custom buttons toolbar on provider dashboard view
(cherry picked from commit 3d763ac)

https://bugzilla.redhat.com/show_bug.cgi?id=1496925
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit f2ab40285c35c3a38b9a4e75f3c4c4878b450a61
Author: Milan Zázrivec <[email protected]>
Date:   Fri Sep 22 10:15:23 2017 +0200

    Merge pull request #2212 from h-kataria/show_custom_buttons_on_provider_dashboard_screen
    
    Fixed code to render custom buttons toolbar on provider dashboard view
    (cherry picked from commit 3d763ac2f26811596b68978e08869c95065f614c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants