Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only count unresolved alerts #2175

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Only count unresolved alerts #2175

merged 1 commit into from
Sep 14, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 14, 2017 •
edited
Loading

Description

MiqAlertStatus can be resolved or not resolved, users are interested only in the none resolved alerts count.

Screenshot
Before fix:

ExtManagementSystem.first.miq_alert_statuses.count
2

screenshot-localhost 3000-2017-09-14-13-43-04

After fix:

ExtManagementSystem.first.miq_alert_statuses.where(:resolved => [false,nil]).count
1

screenshot-localhost 3000-2017-09-14-13-32-03

@yaacov yaacov force-pushed the only-count-unresolved-alerts branch from c2eda6c to 6fe5e5f Compare September 14, 2017 17:30
@miq-bot
Copy link
Member

miq-bot commented Sep 14, 2017

Checked commit yaacov@6fe5e5f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@yaacov
Copy link
Member Author

yaacov commented Sep 14, 2017

@miq-bot add_label bug, compute/containers

@simon3z @ilackarms @moolitayer @zakiva @zeari @himdel @mzazrivec please review

moolitayer
moolitayer approved these changes Sep 14, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
for reference:
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/assets/javascripts/services/alerts_center_service.js#L412

@h-kataria h-kataria self-assigned this Sep 14, 2017
@h-kataria h-kataria added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 14, 2017
@h-kataria h-kataria merged commit 286317b into ManageIQ:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moolitayer moolitayer moolitayer approved these changes

Assignees

@h-kataria h-kataria

Labels
bug compute/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaacov @miq-bot @moolitayer @h-kataria