Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EXP_TODAY, EXP_FROM, EXP_IS from UiConstants #2158

Merged
merged 4 commits into from
Sep 11, 2017

Conversation

europ
Copy link
Member

@europ europ commented Sep 11, 2017

Issue: #1661

Definitions of constants EXP_TODAY, EXP_FROM, EXP_IS were removed from UiConstants. They were moved to ApplicationController::Filter.

@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2017

Checked commits europ/manageiq-ui-classic@171ad2c~...2a85010 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 2 offenses detected

app/views/layouts/exp_atom/_edit_field.html.haml

  • ⚠️ - Line 86 - Avoid more than 3 levels of block nesting.

app/views/layouts/exp_atom/_edit_find.html.haml

  • ⚠️ - Line 72 - Avoid more than 3 levels of block nesting.

@mzazrivec mzazrivec self-assigned this Sep 11, 2017
@mzazrivec mzazrivec added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 11, 2017
@mzazrivec mzazrivec merged commit d1fb3fa into ManageIQ:master Sep 11, 2017
@europ europ deleted the remove-ui-constants-58 branch September 12, 2017 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants