Store the expanded state of the explorer trees locally #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@f399f1b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
So.. what does it do? :) |
|
Well, it stores the tree state in the sessionStorage as the previous implementation. It also expands/collapses the nodes if necessary but for now the ruby code does it for us. A piece of code we want to get rid of in the future 😉 |
|
And why |
|
@himdel because it's the unique identifier of each tree node. Again: we were using this before in the non-angular implementation. In the future I'd like to use a more complex key that consists two elements (type, id) and then we can drop the current key which is just too complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're already storing the state on the server side and sending the tree already expanded when necessary, this doesn't do very much but it's a good start for the API-backed tree builders.
@martinpovolny @himdel