Remove SNAPSHOT_AGES from UiConstants #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
europ
force-pushed
the
remove-ui-constants-56
branch
from
2114cd8 to
19f2aa3
Compare
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-56
branch
from
19f2aa3 to
2ccd31d
Compare
europ
force-pushed
the
remove-ui-constants-56
branch
from
2ccd31d to
79d325e
Compare
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-56
branch
from
79d325e to
43771f7
Compare
|
Checked commit europ@43771f7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/miq_policy_helper.rb
|
|
Rubocop is right, please, fix that:
|
|
@martinpovolny he does that, just not on the line that rubocop complains about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1661
Definition of constant
SNAPSHOT_AGESwas removed fromUiConstants. It was moved to new moduleMiqPolicyHelper.