Remove EXP_COUNT_TYPE, EXP_FIND_TYPE, EXP_TYPES, VM_EXP_TYPES from UiCon… #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
europ
changed the title
|
@europ Can you address the rubocop issues above please? |
europ
force-pushed
the
remove-ui-constants-49
branch
from
0e3bb5b to
f416d46
Compare
europ
force-pushed
the
remove-ui-constants-49
branch
from
f416d46 to
f6cb71b
Compare
|
Checked commit europ@f6cb71b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1661
Definitions of constants
EXP_COUNT_TYPE,EXP_FIND_TYPE,EXP_TYPESandVM_EXP_TYPESwere removed fromUiConstants. They were moved to new moduleExpAtomHelper.