Consider archived nodes for single provider dashboard #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeari
force-pushed
the
archived_nodes_dashboard
branch
from
cbdad7b to
79b3ce8
Compare
|
Checked commit zeari@79b3ce8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore
realtime_metricstocontainer_dashboard_service.rbwith correct metrics thats include archived nodes. Container projects do not have realtime metrics (like ems, they only have rollups) so the projects dashboard should not be affected.@zakiva Please review
cc @simon3z
@miq-bot add_label compute/containers