Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASSIGN_TOS from UiConstants #2082

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

europ
Copy link
Member

@europ europ commented Sep 4, 2017

Issue: #1661

Definition of constant ASSIGN_TOS was removed from UiConstants. It was moved to ViewHelper.

Compute -> Clouds -> Providers

@europ europ changed the title Remove ASSIGN_TOS from UiConstants [WIP] Remove ASSIGN_TOS from UiConstants Sep 4, 2017
@miq-bot miq-bot added the wip label Sep 4, 2017
@europ
Copy link
Member Author

europ commented Sep 4, 2017

ping @martinpovolny
Is ViewHelper the right place for this constant ? 😳

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2017

This pull request is not mergeable. Please rebase and repush.

@europ europ force-pushed the remove-ui-constants-46 branch from 832ca4f to 16cb3b5 Compare September 5, 2017 06:29
@europ europ force-pushed the remove-ui-constants-46 branch from 16cb3b5 to da22c83 Compare September 5, 2017 12:23
@europ europ changed the title [WIP] Remove ASSIGN_TOS from UiConstants Remove ASSIGN_TOS from UiConstants Sep 5, 2017
@miq-bot miq-bot removed the wip label Sep 5, 2017
@europ europ force-pushed the remove-ui-constants-46 branch 2 times, most recently from 6ea86ff to 4c5d50a Compare September 5, 2017 13:21
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2017

This pull request is not mergeable. Please rebase and repush.

@martinpovolny
Copy link
Member

Please, try to make Rubocop less unhappy. And rebase ;-)

@europ europ force-pushed the remove-ui-constants-46 branch from 4c5d50a to 008494a Compare September 6, 2017 17:45
@europ
Copy link
Member Author

europ commented Sep 6, 2017

Okey, I will fix it, but it will be less readable I think. I was asking @romanblanco about this and he agreed.

@europ europ force-pushed the remove-ui-constants-46 branch 2 times, most recently from 0cf74c1 to 3136417 Compare September 6, 2017 18:22
@europ europ changed the title Remove ASSIGN_TOS from UiConstants [WIP] Remove ASSIGN_TOS from UiConstants Sep 6, 2017
@europ europ force-pushed the remove-ui-constants-46 branch from 3136417 to 56f538f Compare September 6, 2017 18:33
@miq-bot miq-bot added the wip label Sep 6, 2017
@europ europ force-pushed the remove-ui-constants-46 branch from 56f538f to 3c3b18f Compare September 6, 2017 18:52
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2017

Checked commit europ@3c3b18f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 10 offenses detected

app/helpers/term_of_service_helper.rb

app/views/chargeback/_cb_assignments.html.haml

  • ⚠️ - Line 12 - Line is too long. [162/160]

app/views/miq_policy/_alert_profile_assign.html.haml

  • ⚠️ - Line 17 - Line is too long. [181/160]

@europ europ changed the title [WIP] Remove ASSIGN_TOS from UiConstants Remove ASSIGN_TOS from UiConstants Sep 6, 2017
@miq-bot miq-bot removed the wip label Sep 6, 2017
@mzazrivec mzazrivec self-assigned this Sep 7, 2017
@mzazrivec mzazrivec added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 7, 2017
@mzazrivec mzazrivec merged commit 1238919 into ManageIQ:master Sep 7, 2017
@europ europ deleted the remove-ui-constants-46 branch September 7, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants