-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Live Migrate actions to the task queue. #208
Conversation
348eaf6
to
a7f07c6
Compare
@miq-bot remove_label wip,pending_backend |
This is what I get when I run the instance migration on a OpenStack cloud provider:
|
} | ||
task_id = @record.class.live_migrate_queue(session[:userid], @record, options) | ||
unless task_id.kind_of?(Integer) | ||
add_flash(_("Instance live migration task %{id} failed.") % {:id => task_id.to_s}, :error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble understanding the above logic. If task_id
is not integer, we're gonna render a flash error
telling that a task with id task_id
failed? What will task_id
contain at this point? Will it really be the task's id?
Then it would be an integer, right? But at the same time it wouldn't pass the unless task_id.kind_of?(Integer)
condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are of course right, the id in the flash error is mistaken.
I don't get that route problem. The route is defined in this patch, and when I run it locally the requests to wait_for_task succeed. |
f3d2441
to
22a205f
Compare
The routing error I shown above will show when you navigate to OpenStack Cloud Provider -> |
Ah, I see. Fix incoming. |
22a205f
to
946e9de
Compare
Checked commits mansam/manageiq-ui-classic@cbe6c13~...946e9de with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/application_controller/ci_processing.rb
|
Use the task queue for Live Migrate instead of calling the action directly from the UI.
Depends on ManageIQ/manageiq#13491 which contains the backend changes.