Support oVirt network provider #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlonaKaplan could you add some screen shots? Thx, Dan |
epwinchell
reviewed
Sep 28, 2017
There was a problem hiding this comment.
@AlonaKaplan Can you create a symlink to vendor-redhat.svg rather than copying it? Thanks.
cc\ @skateman
|
@epwinchell true story, we ❤️ symlinks |
|
Done- created a symlink. |
|
This pull request is not mergeable. Please rebase and repush. |
Ladas
approved these changes
Oct 3, 2017
There was a problem hiding this comment.
Looks good. Depends on ManageIQ/manageiq-providers-ovirt#90
then the CI should pass
martinpovolny
approved these changes
Oct 3, 2017
|
Checked commits AlonaKaplan/manageiq-ui-classic@36e6603~...256122d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes-