Dialog editor - don't show error modal when validation failed #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before:
API.get('/foo') - shows error modal on any 4** and 5** response
API.get.noErrorModal('/foo') - never shows error modal
now:
API.get('/foo') - shows error modal on any 4** and 5** response
API.get('/foo', { skipErrors: true }) - never shows error modal
API.get('/foo', { skipErrors: [400, 404] }) - show error modal an all 4** and 5**, except for 400 and 404
(for methods taking data (put, post), options is the third argument)
validation errors from servers are handled by flashing the message, no need to show the error modal - skipping any 400 responses https://bugzilla.redhat.com/show_bug.cgi?id=1486688
himdel
changed the title
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/fcc6248a4432482398120412dbdb4565e4042457~...d99ae16896de0105d3ee5572fda393b710abcd83 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1976, we enabled the error modal for API use.
This is one of the places where an error from the API was already being handled by the code, and should not have an error modal.
https://bugzilla.redhat.com/show_bug.cgi?id=1486688
This also changes the API error modal opt-out mechanism:
before:
API.get('/foo')- shows error modal on any 4** and 5** responseAPI.get.noErrorModal('/foo')- never shows error modalnow:
API.get('/foo')- shows error modal on any 4** and 5** responseAPI.get('/foo', { skipErrors: true })- never shows error modalAPI.get('/foo', { skipErrors: [400, 404] })- show error modal an all 4** and 5**, except for 400 and 404(for methods taking data (put, post), options is the third argument)