[WIP] Fix widget maximize operation by checking other condition in addition to linked MiqGroup #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
changed the title
…esult id saved in session.
yrudman
force-pushed
the
check-if-report-available-to-user
branch
from
7d8e9d2 to
672507d
Compare
…_id, instead group name saved as part of value in miq_report_result.userid column (example: widgets). IN this case we need to parse that column to check if vurrent user has access right to generated data https://bugzilla.redhat.com/show_bug.cgi?id=1492174
yrudman
force-pushed
the
check-if-report-available-to-user
branch
from
672507d to
6c1d97f
Compare
yrudman
changed the title
|
@miq-bot remove-label wip |
|
Checked commits yrudman/manageiq-ui-classic@e5d8e1c~...6c1d97f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
reviewed
Sep 19, 2017
| rr = MiqReportResult.for_user(current_user).find(search_id) | ||
| rr = MiqReportResult.find(search_id) | ||
| unless rr.available_to_user?(current_user) | ||
| add_flash(_("Current user does not permission to view report data id: #{search_id}"), :error) |
There was a problem hiding this comment.
@yrudman typo missing "have" in the flash message
|
@yrudman do you have a screenshot of screen showing flash message "Current user does not have permission to view report data id: xxx" |
yrudman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is follow-up to #1627, #1827
blocked by:
MiqReportResult#available_to_user?BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1492174
Issue:
Full Screen,PDF Download, andZoom inoperations on widget in Dashboard throw error. Reason for error - miq_group_id column which driving access inMiqReportResult.for_user(user)was not setSolution: Check other access rules in addition to linked group
Before:
After:
\cc @gtanzillo