Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds error on dialog field association circular reference catch #2056

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Adds error on dialog field association circular reference catch #2056

merged 2 commits into from
Oct 27, 2017

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Aug 30, 2017 •
edited
Loading

Shows UI error for importing a dialog whose references are circular.

Links
Depends on: ManageIQ/manageiq#15909

@d-m-u d-m-u mentioned this pull request Aug 30, 2017
Merged
@d-m-u d-m-u changed the title Adds error on dialog field association circular reference catch [WIP] Adds error on dialog field association circular reference catch Aug 31, 2017
@miq-bot miq-bot added the wip label Aug 31, 2017
@d-m-u d-m-u force-pushed the dialog_field_circular_association_reference_error branch 3 times, most recently from 7419b34 to c3db418 Compare August 31, 2017 21:23
@d-m-u d-m-u changed the title [WIP] Adds error on dialog field association circular reference catch Adds error on dialog field association circular reference catch Sep 20, 2017
@miq-bot miq-bot removed the wip label Sep 20, 2017
@d-m-u d-m-u changed the title Adds error on dialog field association circular reference catch [WIP] Adds error on dialog field association circular reference catch Sep 26, 2017
@miq-bot miq-bot added the wip label Sep 26, 2017
@d-m-u d-m-u force-pushed the dialog_field_circular_association_reference_error branch from c3db418 to 4809778 Compare September 27, 2017 13:25
@d-m-u d-m-u changed the title [WIP] Adds error on dialog field association circular reference catch Adds error on dialog field association circular reference catch Sep 27, 2017
@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 27, 2017 •
edited
Loading

Tests when symlinked to the linked main repo PR ran and passed:
screen shot 2017-09-27 at 9 31 30 am
(they're failing here cause the linked PR has the custom error definition.)

@miq-bot miq-bot removed the wip label Sep 27, 2017
@dclarizio dclarizio requested a review from eclarizio September 28, 2017 16:44
@dclarizio
Copy link

@d-m-u is this a bug fix (need BZ) or an enhancement?

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 28, 2017

@miq-bot add_label enhancement

eclarizio
eclarizio approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, will just have to wait until the linked PR gets merged as Drew mentioned, otherwise boom goes the build.

@d-m-u d-m-u force-pushed the dialog_field_circular_association_reference_error branch 2 times, most recently from b7c7af8 to 42d53fc Compare October 25, 2017 15:47
@d-m-u d-m-u closed this Oct 25, 2017
@d-m-u d-m-u reopened this Oct 25, 2017
@gmcculloug
Copy link
Member

@h-kataria Back-end PR has been merged.

@d-m-u d-m-u closed this Oct 27, 2017
@d-m-u d-m-u reopened this Oct 27, 2017
@d-m-u d-m-u force-pushed the dialog_field_circular_association_reference_error branch from 42d53fc to bec5c49 Compare October 27, 2017 01:55
@d-m-u d-m-u force-pushed the dialog_field_circular_association_reference_error branch from bec5c49 to a32e8cc Compare October 27, 2017 02:00
@miq-bot
Copy link
Member

miq-bot commented Oct 27, 2017

Checked commits d-m-u/manageiq-ui-classic@e11e7cf~...a32e8cc with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@h-kataria h-kataria modified the milestone: Sprint 72 Ending Oct 30, 2017 Oct 27, 2017
@h-kataria
Copy link
Contributor

merging, since test failures are not related to changes in this PR

@h-kataria h-kataria added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 27, 2017
@h-kataria h-kataria merged commit 96652fe into ManageIQ:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclarizio eclarizio eclarizio approved these changes

Assignees

@h-kataria h-kataria

Labels
automation/automate enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-m-u @dclarizio @gmcculloug @miq-bot @h-kataria @eclarizio