Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TASK_STATES from UiConstants #2051

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Remove TASK_STATES from UiConstants #2051

merged 1 commit into from
Aug 30, 2017

Conversation

europ
Copy link
Member

@europ europ commented Aug 30, 2017 •
edited
Loading

Issue: #1661

Definition of constant TASK_STATES was removed from UiConstants and moved to MiqTaskController. Prefix MiqTaskController:: was added to TASK_STATES only in one file miq_task_controller_spec.rb.

@miq-bot
Copy link
Member

miq-bot commented Aug 30, 2017

Checked commit europ@4338ec1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@martinpovolny martinpovolny merged commit 9c26bd0 into ManageIQ:master Aug 30, 2017
@martinpovolny martinpovolny self-assigned this Aug 30, 2017
@martinpovolny martinpovolny added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 30, 2017
@europ europ deleted the remove-ui-constants-43 branch August 30, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
tasks technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@europ @miq-bot @martinpovolny