Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage to MW Add JDBC Driver #2030

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Fix breakage to MW Add JDBC Driver #2030

merged 1 commit into from
Aug 29, 2017

Conversation

mtho11
Copy link
Contributor

@mtho11 mtho11 commented Aug 28, 2017

This is a fix for a breakage in the Middleware JDBC Add JDBC Driver Dialogs from the middleware server page as identified by MW QE issue:
ManageIQ/manageiq-providers-hawkular#33

This page just recently started producing the following:
add-jdbc-driver-bug

Here is the page restored to it's original condition:
add-jdbc-good

Looks like original cause is cut-n-paste error in: #1903

cc @himdel

@mtho11
Copy link
Contributor Author

mtho11 commented Aug 28, 2017

@miq-bot add_label middleware, bug, angular dialogs

@mtho11
Copy link
Contributor Author

mtho11 commented Aug 28, 2017

@miq-bot
Copy link
Member

miq-bot commented Aug 28, 2017

Checked commit https://github.com/mtho11/manageiq-ui-classic/commit/12ba888513bac5109ad2538bf591850d8d3f2ec1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Aug 29, 2017
@mzazrivec mzazrivec added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 29, 2017
@mzazrivec mzazrivec merged commit 83fbe7f into ManageIQ:master Aug 29, 2017
@mtho11 mtho11 deleted the mw-add-jdbc-driver-bug2 branch August 29, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants