Remove WIDGET_TYPES, SINGULAR_WIDGET_TYPES from UiConstants #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The constants are not the same. It's singular vs plural. There's a hint in the name |
europ
force-pushed
the
remove-ui-constants-41
branch
2 times, most recently
from
514e7e5 to
64699b1
Compare
|
Please, fix the rubocop warning. |
europ
force-pushed
the
remove-ui-constants-41
branch
from
64699b1 to
2b2ee1c
Compare
|
Checked commits europ/manageiq-ui-classic@7664522~...2b2ee1c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@martinpovolny fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1661
Constant
SINGULAR_WIDGET_TYPESwas replaced with same constantWIDGET_TYPES. Definition of constantSINGULAR_WIDGET_TYPESwas removed fromUiConstants.Definition of constant
WIDGET_TYPESwas removed fromUiConstantsand moved toReportController. PrefixReportController::was added to every occurrence ofWIDGET_TYPES.