Remove FROM_DAYS from UiConstants #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
europ
force-pushed
the
remove-ui-constants-36
branch
from
9136bc1 to
e91be09
Compare
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-36
branch
from
e91be09 to
fae8e56
Compare
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-36
branch
from
fae8e56 to
f372e2e
Compare
europ
force-pushed
the
remove-ui-constants-36
branch
2 times, most recently
from
b78c103 to
88dd5e7
Compare
europ
force-pushed
the
remove-ui-constants-36
branch
from
88dd5e7 to
37f056c
Compare
|
Checked commits europ/manageiq-ui-classic@5b9f8b1~...37f056c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/report/_form_styling.html.haml
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1661
Definition of constant
FROM_DAYSwas removed fromUiConstantsand moved toViewHelper. PrefixViewHelper::was added to every occurrence ofFROM_DAYS.Cloud Intel->Reports->Reports->Virtual Machines->Configuration->Add new Report->Styling