Menu active item fixes

[martinpovolny]

Fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=1479373
https://bugzilla.redhat.com/show_bug.cgi?id=1479393
https://bugzilla.redhat.com/show_bug.cgi?id=1479385
https://bugzilla.redhat.com/show_bug.cgi?id=1479359
https://bugzilla.redhat.com/show_bug.cgi?id=1472844
https://bugzilla.redhat.com/show_bug.cgi?id=1471115

ping @h-kataria

[miq-bot]

Checked commits martinpovolny/manageiq-ui-classic@0fae152~...41b477d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 3 offenses detected

app/controllers/automation_manager_controller.rb

• ❗ - Line 12, Col 3 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

app/controllers/configuration_job_controller.rb

• ❗ - Line 73, Col 3 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

app/controllers/middleware_domain_controller.rb

• ❗ - Line 20, Col 3 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

[simaishi]

@martinpovolny @h-kataria Can/should this be backported to Fine branch? The associated BZs have the backport flag set.

[martinpovolny]

@simaishi : I'd say why not. Is it a clean cherry-pick?

[simaishi]

Yes, a clean cherry-pick.

[martinpovolny]

@simaishi, related fix: #2368

[simaishi]

Fine backport details:

$ git log -1
commit 339e765823f76787b160dd35c74b9e24205bdfc3
Author: Harpreet Kataria <[email protected]>
Date:   Wed Aug 16 16:03:43 2017 -0400

    Merge pull request #1915 from martinpovolny/menu_active_fixes
    
    Menu active item fixes
    (cherry picked from commit 6c543ea8c187ca2fdb387e2f3d56763d525f8032)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1498516
    https://bugzilla.redhat.com/show_bug.cgi?id=1498511
    https://bugzilla.redhat.com/show_bug.cgi?id=1498518
    https://bugzilla.redhat.com/show_bug.cgi?id=1498506
    https://bugzilla.redhat.com/show_bug.cgi?id=1498544