Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dupe warning message in Optimize Bottlenecks #1886

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Aug 10, 2017

Ensure we do not generate duplicate warning message on an previously generated and empty Bottlenecks Timeline report.

https://bugzilla.redhat.com/show_bug.cgi?id=1479411

Screen shot prior to fix:

bz1479411_bottlenecks duplicate messages

=================
Screen shot post fix:

bz1479411_bottlenecks display post fix

@miq-bot
Copy link
Member

miq-bot commented Aug 10, 2017

Checked commit GregP@933280a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@GregP
Copy link
Contributor Author

GregP commented Aug 10, 2017

@h-kataria Ready for review.

@mzazrivec mzazrivec self-assigned this Aug 14, 2017
@mzazrivec mzazrivec added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 14, 2017
@mzazrivec mzazrivec merged commit 1e3d46a into ManageIQ:master Aug 14, 2017
simaishi pushed a commit that referenced this pull request Aug 14, 2017
Delete dupe warning message in Optimize Bottlenecks
(cherry picked from commit 1e3d46a)

https://bugzilla.redhat.com/show_bug.cgi?id=1481439
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 21f41811e627b630a25bbf3ce5c8417150d3317f
Author: Milan Zázrivec <[email protected]>
Date:   Mon Aug 14 11:49:15 2017 +0200

    Merge pull request #1886 from GregP/dupe_msg_bottlenecks
    
    Delete dupe warning message in Optimize Bottlenecks
    (cherry picked from commit 1e3d46a9720544cd960d727e4ea93eb1a8ea8a6f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants