Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong breadcrumb link when click on Service Catalog #1873

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Fix wrong breadcrumb link when click on Service Catalog #1873

merged 1 commit into from
Aug 15, 2017

Conversation

PanSpagetka
Copy link
Contributor

@PanSpagetka PanSpagetka commented Aug 10, 2017 •
edited
Loading

Fix wrong breadcrumb link when click on Service Catalog

Steps to Reproduce:

  1. Create a service of type orchestration.
  2. Do some operations(click here and there) on Service- catalog items
  3. Now go to MyService click on that service . On service detail page , click on stack . Stack page will be shown with "Service catalog item" link at the top.
  4. Click on "Service Catalog Item " Page does not exist

https://bugzilla.redhat.com/show_bug.cgi?id=1469820

@PanSpagetka PanSpagetka force-pushed the breadcrumb-link-service-cat branch from 5e8d807 to b8a80ce Compare August 10, 2017 07:25
@miq-bot
Copy link
Member

miq-bot commented Aug 10, 2017

Checked commit PanSpagetka@b8a80ce with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@romanblanco
Copy link
Member

@miq-bot assign @romanblanco

romanblanco
romanblanco approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on appliance, fixes the issue 👍

@romanblanco
Copy link
Member

ping @martinpovolny @himdel

@mzazrivec mzazrivec self-assigned this Aug 15, 2017
@mzazrivec mzazrivec added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 15, 2017
@mzazrivec mzazrivec merged commit d052bb0 into ManageIQ:master Aug 15, 2017
simaishi pushed a commit that referenced this pull request Aug 15, 2017
@mzazrivec @simaishi
Merge pull request #1873 from PanSpagetka/breadcrumb-link-service-cat
cdb049e 
Fix wrong breadcrumb link when click on Service Catalog
(cherry picked from commit d052bb0)

https://bugzilla.redhat.com/show_bug.cgi?id=1481849
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit cdb049eee25c686aea73861d8e8120d81dc343f0
Author: Milan Zázrivec <[email protected]>
Date:   Tue Aug 15 08:22:30 2017 +0200

    Merge pull request #1873 from PanSpagetka/breadcrumb-link-service-cat
    
    Fix wrong breadcrumb link when click on Service Catalog
    (cherry picked from commit d052bb07f506abacc1a222187cf290a198383abf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees

@romanblanco romanblanco

@mzazrivec mzazrivec

Labels
bug fine/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PanSpagetka @miq-bot @romanblanco @simaishi @mzazrivec