Reverse-merge tree params if the tree is already in the sandbox #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
fix-datastore-relationload
branch
from
3c2858b to
1b9743d
Compare
If the tree was already in the sandbox, the updated params were simply ignored. This causes issues when loading an explorer screen with a tree. The reverse-merging doesn't change the already set values for a tree, just adds the new ones that will fix the issue. https://bugzilla.redhat.com/show_bug.cgi?id=1478355
skateman
force-pushed
the
fix-datastore-relationload
branch
from
1b9743d to
48fd58e
Compare
|
Checked commit skateman@48fd58e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2017
Reverse-merge tree params if the tree is already in the sandbox (cherry picked from commit 0591c6e) https://bugzilla.redhat.com/show_bug.cgi?id=1480002
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tree was already in the sandbox, the updated params were simply ignored. This causes issues when loading an explorer screen with a tree. The reverse-merging doesn't change the already set values for a tree, just adds the new ones that will fix the issue.
Steps to reproduce:
After this fix:
https://bugzilla.redhat.com/show_bug.cgi?id=1478355