Remove TIMER_DAYS,TIMER_HOURS,TIMER_WEEKS,TIMER_MONTHS from UiConstants

[europ]

Issue: #1661

Constants TIMER_DAYS,TIMER_HOURS,TIMER_WEEKS,TIMER_MONTHS have been removed from UiConstants. Definitions of constants TIMER_DAYS,TIMER_HOURS,TIMER_WEEKS,TIMER_MONTHS were moved to ReportHelper. Prefix ReportHelper:: was added to every occurrence of these constants.

Cloud Intel -> Reports -> Schedules -> Copy of ChargeBack by Project -> Configuration -> Edit this Schedule

[europ]

@miq-bot assign @romanblanco

[romanblanco]

@europ isn't manageiq-ui-classic/app/helpers/report_helper/timer.rb better place for the constants?

[europ]

Is manageiq-ui-classic/app/controllers/mixins/time_helper.rb a better place than manageiq-ui-classic/app/helpers/report_helper/timer.rb for these constants?

/cc @martinpovolny @romanblanco

[martinpovolny]

view_helper is included everywhere and the constants are only relevant for reports. That means that @romanblanco is right.

@europ isn't manageiq-ui-classic/app/helpers/report_helper/timer.rb better place for the constants?

[miq-bot]

Checked commits europ/manageiq-ui-classic@d577f5d~...d0ebb4b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 2 offenses detected

app/helpers/report_helper/timer.rb

• ❗ - Line 2, Col 1 - Style/EmptyLinesAroundModuleBody - Extra empty line detected at module body beginning.
• ❗ - Line 37, Col 1 - Style/TrailingWhitespace - Trailing whitespace detected.