Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decorator icon cleanup #181

Merged
merged 1 commit into from
Jan 19, 2017
Merged

decorator icon cleanup #181

merged 1 commit into from
Jan 19, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Jan 17, 2017 •
edited by miq-bot
Loading

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2017

@epwinchell Cannot apply the following label because they are not recognized: euwe

@epwinchell
Copy link
Contributor Author

@miq-bot add_label technical debt, euwe/no

@epwinchell
Copy link
Contributor Author

@miq-bot assign @himdel

@himdel
Copy link
Contributor

himdel commented Jan 19, 2017

So, we can't remove these because those are still being used for single quadicons - http://localhost:3000/orchestration_stack/show_list?type=tile for example

@himdel
Copy link
Contributor

himdel commented Jan 19, 2017 •
edited
Loading

(But I don't see any technical reasons why quadicons couldn't use the fonticon as well, they just don't do that yet - created an issue: #198)

@epwinchell epwinchell closed this Jan 19, 2017
@epwinchell epwinchell reopened this Jan 19, 2017
@himdel
Copy link
Contributor

himdel commented Jan 19, 2017

Uh, can you fix the rubocop thing too please?

himdel
himdel reviewed Jan 19, 2017
View reviewed changes
app/decorators/miq_request_decorator.rb
"pficon pficon-ok"
when "error"
"pficon pficon-error-circle-o"
# else - handled in application controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is not true here anymore..

himdel
himdel reviewed Jan 19, 2017
View reviewed changes
app/decorators/miq_request_decorator.rb
end

def listicon_image
case request_status.to_s.downcase
when "ok"
"100/checkmark.png"
"pficon pficon-ok"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken?

himdel
himdel reviewed Jan 19, 2017
View reviewed changes
app/decorators/miq_request_decorator.rb
when "error"
"100/x.png"
# else - handled in application controller
# "100/#{@listicon.downcase}.png"
"pficon pficon-error-circle-o"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@epwinchell
Copy link
Contributor Author

@himdel fixed

@himdel himdel added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 19, 2017
@himdel
Copy link
Contributor

himdel commented Jan 19, 2017

Thanks! merging when green...

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/ad0346a77ebe4068861d2a26a865a2511ef1163e with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

@himdel himdel merged commit f8f252b into ManageIQ:master Jan 19, 2017
@epwinchell epwinchell deleted the decorator_font_icon_cleanup branch October 25, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel left review comments

Assignees

@himdel himdel

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epwinchell @miq-bot @himdel