Redirecting to 'show list' after deleting a 'cloud network'

[AlonaKaplan]

Currently it stays in the deleted network form. It is not standard. For example, when 'cloud subnet' is deleted it is redirected to the subnets list.

[AlonaKaplan]

please review @tzumainn @Ladas

[tzumainn]

@gildub sorry, this one too!

[Ladas]

@himdel can you point us to what is the right way? The flash message passing should be automatic?

[himdel]

Well, this works, but yeah we shouldn't be passing these flash messages as params if we can help it.

For example, AnsibleCredentialController and AnsibleRepositoryController do...

    session[:flash_msgs] = @flash_array
    javascript_redirect :action => 'show_list'

Similarly, CloudVolumeController, CloudSubnetController and NetworkRouterController do...

      drop_breadcrumb(:name => 'dummy', :url => " ") # missing a bc to get correctly back so here's a dummy
      session[:flash_msgs] = @flash_array.dup if @flash_array
      redirect_to(previous_breadcrumb_url)

👉 I guess it'd be best to follow GenericFormMixin though, which should be the most current and generic...

        session[:flash_msgs] = @flash_array.dup if @flash_array
        javascript_redirect(previous_breadcrumb_url)

(feel free to use :action => 'show_list' if previous_breadcrumb_url proves impossible to use, but prefer the latter, since you can come to most details screens from multiple sources (list of all networks vs. a list of networks under a provider, etc.))

But, if we're standardizing the delete behaviour, we should probably fix all of them:

• CloudVolumeSnapshotController just calls render_flash same as here before this PR

• these call javascript_redirect with the first flash message, same as here now:

  • SecurityGroupController
  • CloudTenantController
  • FloatingIpController

[gildub]

@tzumainn, catching up too...

[gildub]

This is definitely needed.

[himdel]

@AlonaKaplan just a heads up (no pressure), this is now waiting for you :)

[miq-bot]

Checked commit AlonaKaplan@ebe330a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[AlonaKaplan]

@dankenigsberg

[himdel]

LGTM, tested in the UI :)

[alexander-demicev]

@miq-bot add_label fine/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1502736

[simaishi]

Fine backport details:

$ git log -1
commit 5ccd31e1b2033f5cb2fa6a7461b65d69ad78d342
Author: Martin Hradil <[email protected]>
Date:   Mon Sep 11 15:02:08 2017 +0000

    Merge pull request #1809 from AlonaKaplan/del_net
    
    Redirecting to 'show list' after deleting a 'cloud network'
    (cherry picked from commit eb5a9dce497a338b0efddc467e8f09ebd3959df8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1512667