Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary BG_COLORS and bg_color_changed #1802

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Removed unnecessary BG_COLORS and bg_color_changed #1802

merged 1 commit into from
Aug 3, 2017

Conversation

europ
Copy link
Member

@europ europ commented Aug 2, 2017 •
edited
Loading

Issue: #1661

Constant BG_COLORS has been removed from UiConstants.
Method bg_color_changed has been removed from ConfigurationController.

@europ
Copy link
Member Author

europ commented Aug 2, 2017

@miq-bot assign @skateman

@europ europ force-pushed the remove-ui-constants-17 branch from e20fd05 to ccf14d3 Compare August 2, 2017 10:21
@europ europ changed the title Remove BG_COLORS from UiConstants Removed unnecessary BG_COLORS and bg_color_changed Aug 2, 2017
skateman
skateman approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skateman
Copy link
Member

skateman commented Aug 2, 2017

@miq-bot assign @himdel

@miq-bot miq-bot assigned himdel and unassigned skateman Aug 2, 2017
@skateman
Copy link
Member

skateman commented Aug 2, 2017

✂️ 🚽 ✂️ 🚽 ✂️ 🚽 🎉

@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2017

This pull request is not mergeable. Please rebase and repush.

@europ europ force-pushed the remove-ui-constants-17 branch from ccf14d3 to 8841834 Compare August 3, 2017 07:43
@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2017

Checked commit europ@8841834 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 3, 2017
@mzazrivec mzazrivec merged commit d7c1feb into ManageIQ:master Aug 3, 2017
@europ europ deleted the remove-ui-constants-17 branch August 7, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@himdel himdel

Labels
configuration management technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@europ @skateman @miq-bot @himdel @mzazrivec