Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a syntax error in miq_qe.js #1799

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Aug 1, 2017

Before this fix I was getting the following when compiling assets during the container build:

rake aborted!
ExecJS::RuntimeError: SyntaxError: Unexpected token punc «,», expected punc «:» (line: 151371, col: 12, pos: 9599562)

Error
    at new JS_Parse_Error (/tmp/execjs20170801-15221-1azzdltjs:3623:11948)
    at js_error (/tmp/execjs20170801-15221-1azzdltjs:3623:12167)
    at croak (/tmp/execjs20170801-15221-1azzdltjs:3623:22038)
    at token_error (/tmp/execjs20170801-15221-1azzdltjs:3623:22175)
    at expect_token (/tmp/execjs20170801-15221-1azzdltjs:3623:22411)
    at expect (/tmp/execjs20170801-15221-1azzdltjs:3623:22562)
    at /tmp/execjs20170801-15221-1azzdltjs:3624:215
    at /tmp/execjs20170801-15221-1azzdltjs:3623:22954
    at expr_atom (/tmp/execjs20170801-15221-1azzdltjs:3623:30987)
    at maybe_unary (/tmp/execjs20170801-15221-1azzdltjs:3624:1752)
    at expr_ops (/tmp/execjs20170801-15221-1azzdltjs:3624:2523)
    at maybe_conditional (/tmp/execjs20170801-15221-1azzdltjs:3624:2615)
    at maybe_assign (/tmp/execjs20170801-15221-1azzdltjs:3624:3058)
    at expression (/tmp/execjs20170801-15221-1azzdltjs:3624:3384)
new JS_Parse_Error ((execjs):3623:11948)
js_error ((execjs):3623:12167)
croak ((execjs):3623:22038)
token_error ((execjs):3623:22175)
expect_token ((execjs):3623:22411)
expect ((execjs):3623:22562)
(execjs):3624:215
(execjs):3623:22954
expr_atom ((execjs):3623:30987)
maybe_unary ((execjs):3624:1752)
expr_ops ((execjs):3624:2523)
maybe_conditional ((execjs):3624:2615)
maybe_assign ((execjs):3624:3058)
expression ((execjs):3624:3384)
/var/www/miq/vmdb/lib/tasks/evm.rake:77:in `block (4 levels) in <top (required)>'
/var/www/miq/vmdb/lib/tasks/evm_rake_helper.rb:7:in `with_dummy_database_url_configuration'
/var/www/miq/vmdb/lib/tasks/evm.rake:75:in `block (3 levels) in <top (required)>'
Tasks: TOP => assets:precompile
(See full trace by running task with --trace)

@carbonin
Copy link
Member Author

carbonin commented Aug 1, 2017

/cc @karelhala

@miq-bot assign @martinpovolny

@carbonin
Copy link
Member Author

carbonin commented Aug 1, 2017

@carbonin
Copy link
Member Author

carbonin commented Aug 1, 2017

This seems to have been introduced in #1750

@@ -116,7 +116,6 @@ ManageIQ.qe.gtl = {
this.onItemClicked(item, document.createEvent('Event'));
this.$scope.$digest();
}.bind(this),
item,
Copy link
Contributor

@karelhala karelhala Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that was my mistake. Could you please change removing of item to item: item,

Fixing this allows me to compile assets during the container build
@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2017

Checked commit carbonin@464347b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 2, 2017
@mzazrivec mzazrivec self-assigned this Aug 2, 2017
@mzazrivec mzazrivec merged commit b69974d into ManageIQ:master Aug 2, 2017
@carbonin carbonin deleted the fix_syntax_error branch October 13, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants