Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEFAULT_PDF_PAGE_SIZE from UiConstants #1773

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Remove DEFAULT_PDF_PAGE_SIZE from UiConstants #1773

merged 3 commits into from
Jul 28, 2017

Conversation

europ
Copy link
Member

@europ europ commented Jul 27, 2017

Issue: #1661

We have removed DEFAULT_PDF_PAGE_SIZE constant from UiConstants. Definition of DEFAULT_PDF_PAGE_SIZE constant was moved to Editor.

@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commits europ/manageiq-ui-classic@4fd8e0e~...ac2964a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

romanblanco
romanblanco approved these changes Jul 27, 2017
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@mzazrivec mzazrivec self-assigned this Jul 28, 2017
@mzazrivec mzazrivec added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 28, 2017
@mzazrivec mzazrivec merged commit 1bdb441 into ManageIQ:master Jul 28, 2017
@europ europ deleted the remove-ui-constants-12 branch August 7, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees

@mzazrivec mzazrivec

Labels
overview/reporting refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@europ @miq-bot @romanblanco @mzazrivec