Add ui_select dep. to match new ui-components. #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aah.. travis is not ready for npm packages... you also need... diff --git a/tools/ci/setup_js_env.sh b/tools/ci/setup_js_env.sh
index dc6d2ede67..dd4f516646 100644
--- a/tools/ci/setup_js_env.sh
+++ b/tools/ci/setup_js_env.sh
@@ -17,3 +17,5 @@ else
[ $STATUS = 0 ] || exit 1
[ -d vendor/assets/bower_components ] || exit 1
fi
+
+yarn |
|
Checked commits martinpovolny/manageiq-ui-classic@8fd8d7b~...15303b3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ/ui-components#82 was merged in ui-components adding a new dependancy
we need to add that to manageiq-ui-classic too
now the new dialog component is available in the OPS UI and can be used to replace the old code