Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same value was replaced with new constant #1767

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Same value was replaced with new constant #1767

merged 1 commit into from
Jul 28, 2017

Conversation

europ
Copy link
Member

@europ europ commented Jul 27, 2017

Issue: #1661

Issue in pull request: #1757

Three same values are replaced with constant TOP_TABLES_BY_COUNT in manageiq-ui-classic/app/helpers/ops_helper/textual_summary.rb.

@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commit europ@b43e88d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@europ europ changed the title constant was created for same value Same value was replaced with new constant Jul 27, 2017
@mzazrivec mzazrivec self-assigned this Jul 28, 2017
@mzazrivec mzazrivec added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 28, 2017
@mzazrivec mzazrivec merged commit 00a3faf into ManageIQ:master Jul 28, 2017
@europ europ deleted the remove-ui-constants-10 branch August 7, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
refactoring textual summaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@europ @miq-bot @mzazrivec