Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GIGABYTE from UiConstants #1759

Merged
merged 3 commits into from
Jul 26, 2017

Conversation

europ
Copy link
Member

@europ europ commented Jul 26, 2017

Issue: #1661

We have removed GIGABYTE constant from UiConstants. One occurrence of constant GIGABYTE was replaced by its value and the new composite value was saved into new variable.

@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2017

Checked commits europ/manageiq-ui-classic@e79dc13~...5d954c7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@martinpovolny martinpovolny self-assigned this Jul 26, 2017
@martinpovolny martinpovolny merged commit bbcb3fc into ManageIQ:master Jul 26, 2017
@martinpovolny martinpovolny added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 26, 2017
@europ europ deleted the remove-ui-constants-9 branch August 7, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants