Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken titles for automate buttons in new and edit dialog #1716

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Broken titles for automate buttons in new and edit dialog #1716

merged 1 commit into from
Jul 21, 2017

Conversation

pkomanek
Copy link
Contributor

This PR fix a broken titles for a new automate buttons and button groups.

based on: https://bugzilla.redhat.com/show_bug.cgi?id=1379348

Automation/Automate/Customization

before:
before

after:
after

@pkomanek pkomanek changed the title Broken titles fix Broken titles for automate buttons in new and edit dialog Jul 19, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 19, 2017

Checked commit pkomanek@7bebc41 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@pkomanek
Copy link
Contributor Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jul 19, 2017
@martinpovolny martinpovolny merged commit c3b796b into ManageIQ:master Jul 21, 2017
@martinpovolny martinpovolny added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 21, 2017
@martinpovolny martinpovolny self-assigned this Jul 21, 2017
@martinpovolny
Copy link
Member

Can you, please, take a look into unifying the parameters for the replace_right_cell? In a separate PR for master, plese.

@pkomanek pkomanek deleted the broken_title_for_a_new_automate_button branch July 26, 2017 12:42
simaishi pushed a commit that referenced this pull request Aug 9, 2017
@martinpovolny @simaishi
Merge pull request #1716 from pkomanek/broken_title_for_a_new_automat…
a9af6c7 
…e_button

Broken titles for automate buttons in new and edit dialog
(cherry picked from commit c3b796b)

https://bugzilla.redhat.com/show_bug.cgi?id=1479926
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

Fine backport details:

$ git log -1
commit a9af6c7e829988599fc804c38e86ac1227d73b3c
Author: Martin Povolny <[email protected]>
Date:   Fri Jul 21 13:02:05 2017 +0200

    Merge pull request #1716 from pkomanek/broken_title_for_a_new_automate_button
    
    Broken titles for automate buttons in new and edit dialog
    (cherry picked from commit c3b796bc23462dd6092c53d5112882b2284fe8f2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
automation/automate bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkomanek @miq-bot @martinpovolny @simaishi