Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MAX_DESC_LEN from UiConstants #1701

Merged
merged 3 commits into from
Jul 20, 2017

Conversation

europ
Copy link
Member

@europ europ commented Jul 18, 2017

Issue: #1661

We have removed MAX_DESC_LEN constant from UiConstants. MAX_DESC_LEN was moved to ViewHelper and also added ViewHelper prefix for each occurrence of it.

@europ europ changed the title Remove MAX_DESC_LEN from UiConstants [WIP] Remove MAX_DESC_LEN from UiConstants Jul 18, 2017
@europ
Copy link
Member Author

europ commented Jul 18, 2017

@miq-bot add_label wip

@miq-bot miq-bot added the wip label Jul 18, 2017
@europ europ changed the title [WIP] Remove MAX_DESC_LEN from UiConstants Remove MAX_DESC_LEN from UiConstants Jul 18, 2017
@europ
Copy link
Member Author

europ commented Jul 18, 2017

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Jul 18, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 18, 2017

Checked commits europ/manageiq-ui-classic@a0df268~...2d14cb5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
19 files checked, 0 offenses detected
Everything looks fine. 🍰

@martinpovolny
Copy link
Member

Restarting travis.

@martinpovolny martinpovolny merged commit 2353735 into ManageIQ:master Jul 20, 2017
@martinpovolny martinpovolny self-assigned this Jul 20, 2017
@martinpovolny martinpovolny added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 20, 2017
@europ europ deleted the remove-ui-constants-2 branch August 7, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants