Remove MAX_NAME_LEN from UiConstants #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants
branch
from
ed8d161 to
11fc0a3
Compare
move the comment as well please |
europ
force-pushed
the
remove-ui-constants
branch
from
3fa6709 to
11fc0a3
Compare
|
Restarting travis. |
|
Please, rebase. |
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants
branch
from
b50ca4b to
c2ba549
Compare
|
Restarted travis. |
|
Please, rebase. |
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants
branch
from
c2ba549 to
b005e8d
Compare
europ
force-pushed
the
remove-ui-constants
branch
from
b005e8d to
78b3e35
Compare
europ
force-pushed
the
remove-ui-constants
branch
from
78b3e35 to
06bcd38
Compare
|
Checked commits europ/manageiq-ui-classic@2ab52ba~...06bcd38 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1661
We have removed
MAX_NAME_LENconstant fromUiConstants.MAX_NAME_LENwas moved toViewHelperand also addedViewHelperprefix for each occurrence of it.