Autoload UiConstants so other repos don't need to do this #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file pollutes the global namespace for legacy bad reasons. Followup to bundler groups PR: ManageIQ/manageiq#15459 The autoloading of ui constants in manageiq was reverted back here: ManageIQ/manageiq#15518
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 6, 2017
See: ManageIQ/manageiq-ui-classic#1658 Followup to bundler groups PR: ManageIQ#15459 The autoloading of ui constants in manageiq was reverted back here: ManageIQ#15518
1 task
|
Checked commit jrafanie@e811738 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
NickLaMuro
approved these changes
Jul 6, 2017
Closed
|
All right, we should really get rid of this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file pollutes the global namespace for legacy bad reasons.
Followup to bundler groups PR:
ManageIQ/manageiq#15459
The autoloading of ui constants in manageiq was reverted back here:
ManageIQ/manageiq#15518