Updated Specs for Foreman Provider save and Service Dialog Dropdown Options change

[lgalis]

Updated Specs for Foreman Provider save and Service Dialog Dropdown Options changes.

UI specs need to be updated to match the changes in the foreman and master repos:

Links

ManageIQ/manageiq-providers-foreman#5
ManageIQ/manageiq#15456

[dclarizio]

@lgalis looks like one failing test was missed, can you take a look?

[miq-bot]

Checked commits lgalis/manageiq-ui-classic@b7f52b1~...27ae9dd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

[himdel]

Added fine/yes since this should fix

  1) ProviderForemanController #save_provider_foreman will not save with a duplicate name
     Failure/Error: expect(assigns(:flash_array).first[:message]).to include("Name has already been taken")
       expected "Configuration_manager.name has already been taken" to include "Name has already been taken"
     # ./spec/controllers/provider_foreman_controller_spec.rb:143:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:75:in `block (3 levels) in <top (required)>'
     # ./spec/manageiq/spec/support/evm_spec_helper.rb:34:in `clear_caches'
     # ./spec/spec_helper.rb:75:in `block (2 levels) in <top (required)>'

(gitter ☝️ August 8, 2017 2:48 PM)

[simaishi]

Fine backport details:

$ git log -1
commit f0553be7360f37fa7a39635ce476ca4b75363314
Author: Dan Clarizio <[email protected]>
Date:   Wed Jul 5 16:23:28 2017 -0700

    Merge pull request #1656 from lgalis/update_specs_after_foreman_and_master_updates
    
    Updated Specs for Foreman Provider save and Service Dialog Dropdown Options change
    (cherry picked from commit 022fa4315cf28c26baa5c4247e97231d00ad5e8d)