Fix Report full screen view should be in a new window #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
changed the title
|
Checked commit martinpovolny@6e740d8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
martinpovolny
changed the title
|
Tested in UI, Show full screen report indeed does what it says. Hard to say if we'll hit a bug where we send too much data right now (not just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs ui-components ManageIQ/ui-components#79
Report full screen view should be opening a new window. Until this PR, it is replacing the current window.
This was most likely broken with the toolbar component introduction.