Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for tags in metric item #1638

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Check for tags in metric item #1638

merged 1 commit into from
Jul 10, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 2, 2017 •
edited
Loading

Description

When the item tags is missing, lines 162 and 165 fail.

We must check tags array's pre-existence before trying to use it, ( the tags field is not a required filed, and can be nil in the responce ).

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1465562

@yaacov
Copy link
Member Author

yaacov commented Jul 2, 2017

@miq-bot add_label compute/containers

@simon3z @zakiva @moolitayer @himdel please review

@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2017

Checked commit yaacov@fc6397e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@yaacov
Copy link
Member Author

yaacov commented Jul 2, 2017

@miq-bot add_label bug

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1465562

cc: @shalomnaim1

@miq-bot miq-bot added the bug label Jul 2, 2017
@yaacov
Copy link
Member Author

yaacov commented Jul 2, 2017

@miq-bot add_label fine/yes

target is 5.8.2

@mzazrivec mzazrivec merged commit 96b2829 into ManageIQ:master Jul 10, 2017
simaishi pushed a commit that referenced this pull request Aug 4, 2017
@mzazrivec @simaishi
Merge pull request #1638 from yaacov/check-for-tags
299515d 
Check for tags in metric item
(cherry picked from commit 96b2829)

https://bugzilla.redhat.com/show_bug.cgi?id=1478527
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit 299515dfa652ac26f04c66f5a62bbfb800ec0831
Author: Milan Zázrivec <[email protected]>
Date:   Mon Jul 10 08:02:12 2017 +0200

    Merge pull request #1638 from yaacov/check-for-tags
    
    Check for tags in metric item
    (cherry picked from commit 96b28291117a6df83c7c3c34715c5afd19a6ab44)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478527

@chessbyte chessbyte added this to the Sprint 64 Ending Jul 10, 2017 milestone Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/containers fine/backported tagging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yaacov @miq-bot @simaishi @chessbyte @dclarizio @mzazrivec