[FINE] Fix displaying report result #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Rubocop + failing CI :-) |
lpichler
force-pushed
the
fix_displaying_report_result
branch
from
36e5689 to
2110346
Compare
|
@mzazrivec @himdel done 👍 |
|
@miq-bot add_label fine/yes |
|
This pull request is not mergeable. Please rebase and repush. |
lpichler
force-pushed
the
fix_displaying_report_result
branch
from
2110346 to
2cc9710
Compare
lpichler
changed the title
miq-bot
changed the title
when it is nil, report result will be displayed and this condition is satisfied: ./app/views/report/_report_list.html.haml:5
lpichler
force-pushed
the
fix_displaying_report_result
branch
from
2cc9710 to
02f7f2f
Compare
lpichler
changed the title
|
Checked commits lpichler/manageiq-ui-classic@0fd443f~...02f7f2f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caused by: #1488 and first commit of this PR is partial revert of 308fa6f
we need to reach this condition https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/report/_report_list.html.haml#L5 it means that
@report_resultis set to nil.yes, it looks like that there is not need to have
@report_resultbut the revert seems like a safer solution.before
after
@miq-bot add_label bug, blocker
cc @gtanzillo @mzazrivec
@miq-bot assign @himdel
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1465387
master PR #1650