-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a warning for large amount of objects in topology view #1605
Display a warning for large amount of objects in topology view #1605
Conversation
@miq-bot add_label compute/containers, bug |
@Loicavenel would you agree with this solution (may want to read the BZ comments)? |
@dclarizio with OCP we applied a limit to the number of Object you can have in Topology view. Can we use the same logic? @serenamarie125 need your view here |
@Loicavenel there is a limit on the initial display, but the user can add elements after that to see more. If we put a hard limit,then there will be some things the user can never see. |
@dclarizio Ok, that is make a lot of sense. I am just questioning if this is an Info or it should be more like a Warning |
@Loicavenel I personally fill this is what it should look like. Also, from the BZ, this seems to be the intention of @simon3z and the QE.
|
@nimrodshn right now, it's showing the "i", meaning info. It should show a yellow (orange?) warning symbol, since we want a warning, right? |
@dclarizio hmm interesting... I actoually didn't know there was a difference, mind sharing a reference from a different screen how it should look? |
@nimrodshn Here's the reference code for a warning notification: http://www.patternfly.org/pattern-library/communication/inline-notifications/#/code It should require just a couple of minor changes like this:
|
@epwinchell thanks a lot!! |
@nimrodshn can you update the screenshot when handled? Thanks. |
refactored warning
6370a56
to
34a41f3
Compare
@simon3z @dclarizio Fixed 👍 |
Checked commit nimrodshn@34a41f3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Looks much better... this will catch eyes and people may read it ;) |
Display a warning for large amount of objects in topology view (cherry picked from commit 98e0436) https://bugzilla.redhat.com/show_bug.cgi?id=1468296
Fine backport details:
|
Display a warning to the user for large amount of objects in container topology view:
"Note: displaying a very large number of objects in the topology display can adversely affect the performance of some web browsers".
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1455552
Screenshot:
cc: @simon3z @zeari