Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning for large amount of objects in topology view #1605

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

nimrodshn
Copy link
Contributor

@nimrodshn nimrodshn commented Jun 26, 2017

Display a warning to the user for large amount of objects in container topology view:
"Note: displaying a very large number of objects in the topology display can adversely affect the performance of some web browsers".

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1455552
Screenshot:
screenshot from 2017-06-28 10-13-29

cc: @simon3z @zeari

@nimrodshn
Copy link
Contributor Author

@miq-bot add_label compute/containers, bug

@dclarizio
Copy link

dclarizio commented Jun 26, 2017

@Loicavenel would you agree with this solution (may want to read the BZ comments)?

@Loicavenel
Copy link

@dclarizio with OCP we applied a limit to the number of Object you can have in Topology view. Can we use the same logic? @serenamarie125 need your view here

@dclarizio
Copy link

@Loicavenel there is a limit on the initial display, but the user can add elements after that to see more. If we put a hard limit,then there will be some things the user can never see.

@mzazrivec mzazrivec closed this Jun 27, 2017
@mzazrivec mzazrivec reopened this Jun 27, 2017
@Loicavenel
Copy link

@dclarizio Ok, that is make a lot of sense. I am just questioning if this is an Info or it should be more like a Warning

@nimrodshn
Copy link
Contributor Author

@Loicavenel I personally fill this is what it should look like. Also, from the BZ, this seems to be the intention of @simon3z and the QE.

The only other thing that springs to mind would be to display a warning, perhaps appended to the default text: "Click on the legend to show/hide entities, and double click/right click the entities in the graph to navigate to their summary pages."

@dclarizio
Copy link

@nimrodshn right now, it's showing the "i", meaning info. It should show a yellow (orange?) warning symbol, since we want a warning, right?

@nimrodshn
Copy link
Contributor Author

@dclarizio hmm interesting... I actoually didn't know there was a difference, mind sharing a reference from a different screen how it should look?

@epwinchell
Copy link
Contributor

epwinchell commented Jun 27, 2017

@nimrodshn Here's the reference code for a warning notification: http://www.patternfly.org/pattern-library/communication/inline-notifications/#/code

screen shot 2017-06-27 at 2 30 08 pm

It should require just a couple of minor changes like this:

  .alert.alert-warning.alert-dismissable
    %button.close{"aria-hidden" => "true", "data-dismiss" => "alert", :type => "button"}
       %span.pficon.pficon-close
    %span.pficon pficon-warning-triangle-o

@nimrodshn
Copy link
Contributor Author

@epwinchell thanks a lot!!

@simon3z
Copy link
Contributor

simon3z commented Jun 27, 2017

@nimrodshn can you update the screenshot when handled? Thanks.

@nimrodshn nimrodshn force-pushed the display_warning_for_large_pods branch from 6370a56 to 34a41f3 Compare June 28, 2017 07:14
@nimrodshn
Copy link
Contributor Author

@simon3z @dclarizio Fixed 👍
Updated screenshot at the top. ☝️

@miq-bot
Copy link
Member

miq-bot commented Jun 28, 2017

Checked commit nimrodshn@34a41f3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Loicavenel
Copy link

Looks much better... this will catch eyes and people may read it ;)

@dclarizio dclarizio merged commit 98e0436 into ManageIQ:master Jun 28, 2017
@dclarizio dclarizio added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 28, 2017
simaishi pushed a commit that referenced this pull request Jul 6, 2017
Display a warning for large amount of objects in topology view
(cherry picked from commit 98e0436)

https://bugzilla.redhat.com/show_bug.cgi?id=1468296
@simaishi
Copy link
Contributor

simaishi commented Jul 6, 2017

Fine backport details:

$ git log -1
commit 35323b61640bf119100589c434c427ef718bf467
Author: Dan Clarizio <[email protected]>
Date:   Wed Jun 28 08:55:19 2017 -0700

    Merge pull request #1605 from nimrodshn/display_warning_for_large_pods
    
    Display a warning for large amount of objects in topology view
    (cherry picked from commit 98e04363863328c4636b643671b8828eb3eaf725)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1468296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants