Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Create Service Dialog from Container Template" support #1591

Merged

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Jun 22, 2017

Added "Create Service Dialog from Container Template" button on Container Template summary screen.

https://www.pivotaltracker.com/story/show/147301019

screenshot from 2017-06-23 17-15-13

screenshot from 2017-06-23 17-15-28

@h-kataria h-kataria force-pushed the create_dialog_from_container_template branch 6 times, most recently from 21db721 to d15c164 Compare June 23, 2017 20:57
@h-kataria h-kataria changed the title [WIP] - Added "Create Service Dialog from Container Template" support Added "Create Service Dialog from Container Template" support Jun 23, 2017
@h-kataria h-kataria removed the wip label Jun 23, 2017
@h-kataria
Copy link
Contributor Author

@lfu @gmcculloug please review/test

@h-kataria
Copy link
Contributor Author

h-kataria commented Jun 26, 2017

depends on ManageIQ/manageiq#15448

Added "Create Service Dialog from Container Template" button on Container Template summary screen.

https://www.pivotaltracker.com/story/show/147301019
@h-kataria h-kataria force-pushed the create_dialog_from_container_template branch from d15c164 to fff01a7 Compare June 26, 2017 20:38
@miq-bot
Copy link
Member

miq-bot commented Jun 26, 2017

Checked commit h-kataria@fff01a7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 3 offenses detected

app/helpers/application_helper/toolbar/container_template_center.rb

  • ❗ - Line 13, Col 12 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
  • ❗ - Line 16, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

@lfu
Copy link
Member

lfu commented Jun 26, 2017

The generated service dialog looks good! 👍

@Fryguy
Copy link
Member

Fryguy commented Jul 3, 2017

ManageIQ/manageiq#15448 merged.

@h-kataria
Copy link
Contributor Author

@dclarizio backend PR is merged ManageIQ/manageiq#15448

@dclarizio dclarizio merged commit 0f799d9 into ManageIQ:master Jul 3, 2017
@dclarizio dclarizio added this to the Sprint 64 Ending Jul 3, 2017 milestone Jul 3, 2017
@h-kataria h-kataria deleted the create_dialog_from_container_template branch August 16, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants