-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Create Service Dialog from Container Template" support #1591
Merged
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:create_dialog_from_container_template
Jul 3, 2017
Merged
Added "Create Service Dialog from Container Template" support #1591
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:create_dialog_from_container_template
Jul 3, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
create_dialog_from_container_template
branch
6 times, most recently
from
June 23, 2017 20:57
21db721
to
d15c164
Compare
h-kataria
changed the title
[WIP] - Added "Create Service Dialog from Container Template" support
Added "Create Service Dialog from Container Template" support
Jun 23, 2017
@lfu @gmcculloug please review/test |
depends on ManageIQ/manageiq#15448 |
Added "Create Service Dialog from Container Template" button on Container Template summary screen. https://www.pivotaltracker.com/story/show/147301019
h-kataria
force-pushed
the
create_dialog_from_container_template
branch
from
June 26, 2017 20:38
d15c164
to
fff01a7
Compare
Checked commit h-kataria@fff01a7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/application_helper/toolbar/container_template_center.rb
|
The generated service dialog looks good! 👍 |
ManageIQ/manageiq#15448 merged. |
@dclarizio backend PR is merged ManageIQ/manageiq#15448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "Create Service Dialog from Container Template" button on Container Template summary screen.
https://www.pivotaltracker.com/story/show/147301019