Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled 'Delete Saved Report' toolbar button #1589

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Enabled 'Delete Saved Report' toolbar button #1589

merged 2 commits into from
Jun 26, 2017

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Jun 22, 2017 •
edited
Loading

Changing toolbar button visibility behaviour, so it's visible also on Reports Info page

Before:
screenshot from 2017-06-22 17-06-27
After:
screenshot from 2017-06-22 17-04-33

Links

Steps for Testing/QA

(taken from BZ):

1.Navigate to Cloud Intel->Reports->Reports accordion
2.Generate any default reports
3.Go to Saved Report summary page
4.Try to delete saved report

@romanblanco
Copy link
Member Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jun 22, 2017
@romanblanco romanblanco changed the title Enabled 'Delete Saved Report' toolbar button [WIP] Enabled 'Delete Saved Report' toolbar button Jun 22, 2017
@romanblanco
Copy link
Member Author

Update:

marking PR as WIP, as I'm getting error:

[----] F, [2017-06-22T17:10:29.174234 #2962:2b1ffdea2ad4] FATAL -- : Error caught: [ActiveRecord::RecordNotFound] Couldn't find MiqReportResult with 'id'=
/home/rblanco/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activerecord-5.0.4/lib/active_record/core.rb:173:in `find'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/report_controller/saved_reports.rb:98:in `saved_report_delete'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/application_controller/explorer.rb:180:in `generic_x_button'
/home/rblanco/devel/manageiq/plugins/manageiq-ui-classic/app/controllers/report_controller.rb:61:in `x_button'

@miq-bot miq-bot added the wip label Jun 22, 2017
@romanblanco
Copy link
Member Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Enabled 'Delete Saved Report' toolbar button Enabled 'Delete Saved Report' toolbar button Jun 23, 2017
@miq-bot miq-bot removed the wip label Jun 23, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 23, 2017

Checked commits romanblanco/manageiq-ui-classic@3a52e3c~...87a27ae with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Jun 26, 2017
@mzazrivec mzazrivec added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 26, 2017
@mzazrivec mzazrivec merged commit af93bea into ManageIQ:master Jun 26, 2017
simaishi pushed a commit that referenced this pull request Aug 4, 2017
@mzazrivec @simaishi
Merge pull request #1589 from romanblanco/bz1454600
bff7eb1 
Enabled 'Delete Saved Report' toolbar button
(cherry picked from commit af93bea)

https://bugzilla.redhat.com/show_bug.cgi?id=1478400
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit bff7eb125421e0f5e2f4fd1648086e9c05b5c595
Author: Milan Zázrivec <[email protected]>
Date:   Mon Jun 26 10:51:24 2017 +0200

    Merge pull request #1589 from romanblanco/bz1454600
    
    Enabled 'Delete Saved Report' toolbar button
    (cherry picked from commit af93bea4d48ee874b8e6647269082feac5e61a4e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478400

@romanblanco romanblanco deleted the bz1454600 branch August 4, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug fine/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanblanco @miq-bot @simaishi @mzazrivec