Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "items" keyword from list in my settings #1587

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

hstastna
Copy link

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1422416

Remove "items" keyword from the dropdown list of Default Items Per Page.
Remove the keyword also from the dropdown list of Topology Default Items
in View.

Before:
items1

After:
items2

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1422416

Remove "items" keyword from the dropdown list of Default Items Per Page.
Remove the keyword also from the dropdown list of Topology Default Items
in View.
@miq-bot
Copy link
Member

miq-bot commented Jun 22, 2017

Checked commit hstastna@3569485 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 26, 2017
@mzazrivec mzazrivec merged commit 102ecea into ManageIQ:master Jun 26, 2017
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 345c5927175e9d797118271b9d09e453e267b94e
Author: Milan Zázrivec <[email protected]>
Date:   Mon Jun 26 09:09:46 2017 +0200

    Merge pull request #1587 from hstastna/Items_dropdown_my_settings
    
    Remove "items" keyword from list in my settings
    (cherry picked from commit 102ecea8ac132ef284fd31e7c192288121bf671c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1465090

simaishi pushed a commit that referenced this pull request Aug 4, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit fd60ae8f3695e8efe339b986870584f7aa75280c
Author: Milan Zázrivec <[email protected]>
Date:   Mon Jun 26 09:09:46 2017 +0200

    Merge pull request #1587 from hstastna/Items_dropdown_my_settings
    
    Remove "items" keyword from list in my settings
    (cherry picked from commit 102ecea8ac132ef284fd31e7c192288121bf671c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1465089

@mshriver
Copy link
Member

This appears to have removed the 'Items' string from not only the settings pages, but from all of the UI pages where a paginator is included. Was this the intent?

@hstastna
Copy link
Author

@mshriver From my point of view, my answer is yes. I don't see any purpose of leaving "items" in other pages. If you have different opinion or if I am missing something, feel free to leave a comment. Any help is well appreciated. Thank you.

@mshriver
Copy link
Member

@hstastna Noted. Wanted to confirm the intent before CFME QE updates automation to match this new behavior. We'll update for this implementation.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants