-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "items" keyword from list in my settings #1587
Remove "items" keyword from list in my settings #1587
Conversation
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1422416 Remove "items" keyword from the dropdown list of Default Items Per Page. Remove the keyword also from the dropdown list of Topology Default Items in View.
Checked commit hstastna@3569485 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Euwe backport details:
|
Remove "items" keyword from list in my settings (cherry picked from commit 102ecea) https://bugzilla.redhat.com/show_bug.cgi?id=1465089
Fine backport details:
|
This appears to have removed the 'Items' string from not only the settings pages, but from all of the UI pages where a paginator is included. Was this the intent? |
@mshriver From my point of view, my answer is yes. I don't see any purpose of leaving "items" in other pages. If you have different opinion or if I am missing something, feel free to leave a comment. Any help is well appreciated. Thank you. |
@hstastna Noted. Wanted to confirm the intent before CFME QE updates automation to match this new behavior. We'll update for this implementation. Thanks! |
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1422416
Remove "items" keyword from the dropdown list of Default Items Per Page.
Remove the keyword also from the dropdown list of Topology Default Items
in View.
Before:
After: