Allow VMRC connection to a VMware provider accessed through IPv6 #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should put that in a method and call it |
|
Is it enough if I promise that I'll do it in a next refactoring PR? We want this to be backported 😉 |
skateman
force-pushed
the
vmrc-ipv6
branch
2 times, most recently
from
18355eb to
6de83af
Compare
|
Checked commits skateman/manageiq-ui-classic@3e156df~...e2ddcb3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 22, 2017
Allow VMRC connection to a VMware provider accessed through IPv6 (cherry picked from commit bd4525c) https://bugzilla.redhat.com/show_bug.cgi?id=1464118
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMRC has a strange URI form where he doesn't need the brackets around an IPv6 address. The first commit favors the hostname of a provider in the generated URI while the second one removes the brackets from the final URI if required. These two PRs should solve the issue described here:
https://bugzilla.redhat.com/show_bug.cgi?id=1457970#c11