Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed titles and labels for Hosts & Clusters Openstack Providers #1560

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Jun 16, 2017

  • Changed to show Nodes/Deployment Roles as titles for Hosts/Clusters for Openstack Dashboards charts where appropriate on screen.
  • Removed Datastores count chart for Openstack Provider.

https://bugzilla.redhat.com/show_bug.cgi?id=1430241

before
before

after
after

Dashboard for other Infra providers is same as before
after2

@dclarizio please review.

- Changed to show Nodes/Deployment Roles as titles for Hosts/Clusters for Openstack Dashboards charts where appropriate on screen.
- Removed Datastores count chart for Openstack Provider.

https://bugzilla.redhat.com/show_bug.cgi?id=1430241
@h-kataria h-kataria force-pushed the fix_title_on_infra_dashboard branch from bd718aa to 7cd9550 Compare June 16, 2017 17:09
@miq-bot
Copy link
Member

miq-bot commented Jun 16, 2017

Checked commits h-kataria/manageiq-ui-classic@7cd9550~...d176b65 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 3 offenses detected

app/services/ems_infra_dashboard_service.rb

@dclarizio dclarizio merged commit e7f647e into ManageIQ:master Jun 16, 2017
@dclarizio dclarizio added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 16, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 5eaa3e3f0ae33db99ca9a5c467a8d182dc30ebb7
Author: Dan Clarizio <[email protected]>
Date:   Fri Jun 16 11:16:44 2017 -0700

    Merge pull request #1560 from h-kataria/fix_title_on_infra_dashboard
    
    Fixed titles and labels for Hosts & Clusters Openstack Providers
    (cherry picked from commit e7f647e32eb9aaaf0e669d79b80f94d3607bf2ea)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1462361

simaishi pushed a commit that referenced this pull request Jun 16, 2017
Fixed titles and labels for Hosts & Clusters Openstack Providers
(cherry picked from commit e7f647e)

https://bugzilla.redhat.com/show_bug.cgi?id=1462361
@h-kataria h-kataria deleted the fix_title_on_infra_dashboard branch June 22, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants