Add git protocol to URL for Ansible repo

[ZitaNemeckova]

Allow git protocol as valid input

Automate -> Ansible -> Repositories -> Add/Edit Repository -> use URL with git protocol in URL field

Before:
Error message
After:
No error

https://bugzilla.redhat.com/show_bug.cgi?id=1452584

@miq-bot add_label automation/ansible, bug, fine/yes, blocker, wip

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@dac0a63~...68a176d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[ZitaNemeckova]

@miq-bot remove_label wip

[himdel]

So.. looks like I can now use both http urls like https://github.com/ManageIQ/manageiq.git and ssh like [email protected]:ManageIQ/manageiq.git. Tested that Ansible actually seems to sucessfully add such an url 👍.

This does not validate all the possible ways to specify a git url, but does seem to handle the most common one.

Supported:

[email protected]:ManageIQ/manageiq.git
foo.bar@host:
[email protected]:/absolute/path

Valid but not supported:

host:path (makes sense to catch, since the username would be essentially random)
git+https://github.com/ManageIQ/manageiq.git (but you can just skip the git+ bit)
git+ssh://[email protected]/ManageIQ/manageiq.git (this one might be nice if we want to support non-default ports)

[himdel]

@dclarizio Do we want to support non-standard ssh ports in Repository URLs or should we just merge as is?

[dclarizio]

@Fryguy can you chime in on @himdel's question above? Thx, Dan

[Fryguy]

Merge as is. We just do a passthrough to the embedded Tower, so whatever doesn't work is because Tower itself doesn't support that. If we want those features we can push down to Tower.

[simaishi]

Fine backport details:

$ git log -1
commit 9fa86435653fe4b03ac330c9360495cf331dbff7
Author: Dan Clarizio <[email protected]>
Date:   Fri Jun 16 09:37:34 2017 -0700

    Merge pull request #1557 from ZitaNemeckova/add_git_url
    
    Add git protocol to URL for Ansible repo
    (cherry picked from commit bcf147f87d95145b17690fb3d051bc579e47ff61)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1462779