Fix test with ems folder #1547
Merged
Fix test with ems folder #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler unrecognized command 'technical', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
lpichler
force-pushed
the
fix_test_with_ems_folder
branch
from
63d568f to
b97869f
Compare
|
@himdel thanks 👍 |
|
Checked commits lpichler/manageiq-ui-classic@81f8db9~...b97869f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/controllers/application_controller/explorer_spec.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix travis failure https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/242877715
What happened 💥
this test was weird and it was passing by chance. it was revealed by refactoring in ManageIQ/manageiq#15346. The combination of descendant filter and managed filter(tag filter) did not work properly, it displays resources regardless of user's tag filter.
Fix 💉
there is tagged user and he wanted to see EmsFolder, but there is nothing tagged.
So fix is that I am adding vm and tagging it.
Other commits our just clean up.
@miq-bot assign @himdel
@miq-bot technical debt