Fix middleware spec failures on master #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One failure happens because accessing `feed` on a hawkular MiddlewareServer fails when `feed` is `nil`. The other happens because now a hawkular now only finds hawkular datasources, not generic MiddlewareDatasource.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/db36fc971dd4f0fc2775bd73f0c01325cf9530b6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One failure happens because accessing
feedon a hawkular MiddlewareServer fails whenfeedisnil.Adding
feed => ''where needed, but a proper solution will depend on https://github.com/ManageIQ/manageiq-providers-hawkular/pull/20/files#r121929594 - either thatunescapeneeds to be called conditionally, or the factory needs to get updated to not allownil.The other happens because now a hawkular now only finds hawkular datasources, not a generic
MiddlewareDatasource.Cc @h-kataria , @martinpovolny
(Failure on master - https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/242785462)